Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #748 +/- ##
===========================================
+ Coverage 62.51% 62.70% +0.18%
===========================================
Files 705 705
Lines 41988 42118 +130
Branches 6166 6204 +38
===========================================
+ Hits 26249 26410 +161
+ Misses 14844 14773 -71
- Partials 895 935 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ColinLeeo
changed the title
Contributor
|
LGTM |
ColinLeeo
force-pushed
the
tablet_refine
branch
from
a79a4e7 to
dbf86df
Compare
jt2594838
reviewed
Mar 27, 2026
ColinLeeo
force-pushed
the
tablet_refine
branch
from
dbf86df to
3dec88f
Compare
jt2594838
approved these changes
Mar 31, 2026
Comment on lines
+158
to
+160
| value_matrix_[c].string_col->destroy(); | ||
| value_matrix_[c].string_col->~StringColumn(); | ||
| common::mem_free(value_matrix_[c].string_col); |
Contributor
There was a problem hiding this comment.
It is a bit weird to call both destroy and destruction.
Why is destory not included in destruction?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Write 200 x 50000 rows: 15039 ms
Throughput: 664938 rows/s
Write 200 x 50000 rows: 1578 ms
Throughput: 6337140 rows/s